JonasDev17 / qbx-garages

qbox-garages
GNU General Public License v3.0
4 stars 16 forks source link

Convert to oxlib points #3

Closed TonybynMp4 closed 1 year ago

ARSSANTO commented 1 year ago

1st if i enable debug mode its crash the server

ARSSANTO commented 1 year ago

https://github.com/TonybynMp4/qbx-garages/blob/a7705e38c7dfba4d8062c0f3385087ea85393562/client/main.lua#L919

change it too

exports['qb-core']:DrawText(Config.Garages[CurrentGarage]['drawText'], Config.DrawTextPosition)

& please

https://github.com/TonybynMp4/qbx-garages/blob/a7705e38c7dfba4d8062c0f3385087ea85393562/config.lua#L110

Config.DrawTextPosition = 'left-center' -- location of drawtext: left-center, top-center, right-center i forget to do so

ARSSANTO commented 1 year ago

i mean to say Config.Garages[CurrentGarage]['drawText'] this part

TonybynMp4 commented 1 year ago

oh..

ARSSANTO commented 1 year ago

radial menu option also not removing while getting outside of zone

TonybynMp4 commented 1 year ago

radial menu option also not removing while getting outside of zone

should be good now, i forgor that part lol

TonybynMp4 commented 1 year ago

1st if i enable debug mode its crash the server

No idea why that happens, it works fine on my end, tried both the lib zone debug and a garage's debug.

JonasDev17 commented 1 year ago

Merge conflict has to be resolved and the following function needs a better name:

local function SetCurrentGarage()
    CurrentGarage = nil
end

I would probably name it something like "ResetCurrentGarage" since I would expect to be able to use it like SetCurrentGarage(xyz) but since that is not the case I would either add a param and then pass nil to it where you call it or just simply rename it.

TonybynMp4 commented 1 year ago

Done 👍🏻