JonasDoebertin / kirby-visual-markdown

Visual Markdown Editor for Kirby CMS 2
GNU General Public License v3.0
162 stars 17 forks source link

Fixed conflict with Kirby 2.2.2 that was causing redirect every time a tool item is clicked. #66

Closed jcwatson11 closed 8 years ago

jcwatson11 commented 8 years ago

In Kirby 2.2.2, whenever an anchor item is clicked, it redirects the user back to the previous view. This is described in issue #65. This PR fixes that issue by converting the toolbar anchors into buttons and changing related CSS so they still display nicely.

JonasDoebertin commented 8 years ago

This has already been fixed on the develop branch and will ship with the next update (hopefully later today).

If you're interested: the easiest solution to fix this issue (which is caused by the panel, btw. and affects other plugins, too) is to simply give a href attribute to the links. Even if it's just href="#". From my investigations, the issue will only happen when clicking links without it.

JonasDoebertin commented 8 years ago

Still, thanks a lot for your efforts! I appreciate it! 🖖