search

JonasDoebertin / kirby-visual-markdown

Visual Markdown Editor for Kirby CMS 2
GNU General Public License v3.0
162 stars 17 forks source link

tabindex="-1" on the toolbar #84

Closed AhoyLemon closed 7 years ago

AhoyLemon commented 8 years ago

Hi there,

I was just editing a page with my hands off the mouse, and when I tabbed over to the markdown field, it stopped on the H1 button, an additional tab took me to H2.

I feel like intended result here would be to have these buttons ignored by tab, because the premise of visual markdown means those links aren't meant for that kind of accessibility.

Do you think it would be worth doing to add tabindex="-1" to all the links in the toolbar, to avoid this from happening. I'd be happy to put in the PR myself, just wanted to check with you before doing that.

Also, thanks a lot for the plug-in. It's been super useful for me.

JonasDoebertin commented 8 years ago

Seems like a logical step to add the attributes. Feel free to send a PR. 👍

JonasDoebertin commented 7 years ago

Implemented with 76b269b1c4d83836bbbf758249e0c232afc523dd