JonasDoebertin / kirby-visual-markdown

Visual Markdown Editor for Kirby CMS 2
GNU General Public License v3.0
162 stars 17 forks source link

Request: Add optional buttons for all headings #90

Closed heyallan closed 3 years ago

heyallan commented 8 years ago

Add optional buttons for all headings h1 to h6

Also: Don't use H character for headings in button label because it only makes sense for english speakers.

Use 'A' character instead:

 <button>A<sup>1</sup><button>

Output would look like this:

screen shot 2016-04-19 at 8 16 42 pm

Andi-Lo commented 8 years ago

I don't think this change is necessary.

However you can change the icon yourself if you change in: site/fields/markdown/assets/js/visualmarkdowneditor.js on line 198: classname: 'fa fa-font'

Because font-awesome does not provide any other fonts (like A1, A2, A3) you would run into trouble there. Check the full list here of supported icons here: http://fontawesome.io/icons/

heyallan commented 8 years ago
  1. Hacking the plugin is not a solution
  2. Using font-awesome is not the only way to achieve things

I still think making the toolbar more modular is a good idea.

coderica commented 8 years ago

I accidentally created a feature request much along the same lines before seeing this one. I don't agree with the redesign but I do fully agree with adding the other 4 headers. This, along with adding code snippets, seems like a simple and obvious next step, as they are the two main things keeping this plugin from being a complete markdown editor.

The attached photo is of github's comment editor - they include the code block button and I like how they handle making more room with the header dropdown menu. The icon github uses would not only solve Allan's design problem, but makes more sense to people who are not familiar with markdown and are used to something like ms word (which is likely if a developer is installing a visual editor for the content writer, as it is in my case).

screen shot 2016-04-26 at 4 42 20 pm
JonasDoebertin commented 7 years ago

Implementing anything along the lines of @coderica's suggestion might be an option for a later release.