search

JonasJurczok / factorio-todo-list

A distributed todo list mod for Factorio
MIT License
35 stars 21 forks source link

Modified necessary files for compatibility with game version 1.1 #157

Closed Tastaturtaste closed 3 years ago

Tastaturtaste commented 3 years ago

Goal

The goal of this PR is to make the mod compatible with the new game version 1.1.

Questions/Feedback request

I introduced the global variable mod-gui in 'control.lua' with the assignment mod-gui = require("mod-gui") while there is already the statement require "mod-gui" present. Please consider if the statement-expression is still necessary.

I did some basic tests like opening a new task, edit tasks and so on with the new game version and everything seems to work as in previous versions.

Since this is my first time using lua and updating a mod I would like to recieve your feedback.

JonasJurczok commented 3 years ago

Hey,

thanks for the PR.

Some of the changes you made are unnecessary (to the pull request template for example, that would change all future pull requests as well).

I will close this PR but basically copy all your changes into a new one and also credit you there :)

Tastaturtaste commented 3 years ago

Nice, thank you for the mod by the way :)