JonasJurczok / factorio-todo-list

A distributed todo list mod for Factorio
MIT License
35 stars 21 forks source link

Blueprint import #197

Open Psycic101 opened 1 month ago

Psycic101 commented 1 month ago

Added ability to import blueprints and blueprint books as tasks

Goal

Blueprints and blueprint books can now be imported from the encoded export strings. This also supports blueprint books containing more blueprint books. It will add tasks for each blueprint and sub tasks with the count of each entity in the blueprint.

Fixes issue #193

Questions/Feedback request

This is my first foray into Lua and Factorio modding, so I'm happy for any feedback on the code changes. As such, I haven't added any testing, as I don't know how it works (I'm not familiar with faketorio) but I'm happy to work on it with some guidance.

JonasJurczok commented 1 month ago

Hello,

thank you for the contribution.

Faketorio is designed to run tests within factorio with the idea to have automated verification for mod behaviour (see the concept of continuous integration).

However I never developed this further and if I remember correctly UI tests where hard to do.

As I am not really playing Factorio anymore there is also no incentive for me to finish faketorio :)

I will take a look at the code here and give feedback.

Again thank you and welcome to the interesting world of lua development.

Psycic101 commented 1 month ago

Thanks for the feedback!

This feature was something I had thought of when using the plug-in and when I saw it had been suggested by others, I thought I may as well give it a go.

I also hope to get to some of the other issues/suggestions left by others when I get time :)