Open pzerelles opened 11 months ago
Latest commit: dfc32a93242e209b07a7e5391844328c5fc091b0
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Attention: Patch coverage is 94.44444%
with 2 lines
in your changes are missing coverage. Please review.
Project coverage is 94.17%. Comparing base (
dc2f16f
) to head (dfc32a9
).
Files | Patch % | Lines |
---|---|---|
packages/core/src/output-formats.ts | 94.11% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
If I understood the code here correctly, it looks like this isn't really transforming the image in a way that makes it much smaller (e.g. to display just the dominant background color). I think if we were going to add a feature like this we should do it with different transforms that shrink the image in various ways as mentioned in https://github.com/JonasKruckenberg/imagetools/issues/86#issuecomment-1765384288. We don't have to add them all off the bat, but it might be nice to have two options people could choose between to help us figure out the API
It actually takes the smallest size that you specify in the transform for the low quality preview.
Quick Checklist
[x] I have read the contributing guidelines
[x] I have written new tests, as applicable (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)
[x] I have added a changeset, if applicable
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) Feature
What is the new behavior (if this is a feature change)? The picture output can have a low quality base64 image.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?) No
Other information: