JonasKruckenberg / imagetools

Load and transform images using a toolbox :toolbox: of custom import directives!
MIT License
933 stars 59 forks source link

fix: support files with spaces in `generateImageID` #669

Closed pzerelles closed 10 months ago

pzerelles commented 11 months ago
changeset-bot[bot] commented 11 months ago

🦋 Changeset detected

Latest commit: fc62a418f41c6395d67be78c35f616687f8a35cd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | --------------- | ----- | | vite-imagetools | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov[bot] commented 11 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (22ad3a9) 93.60% compared to head (3113847) 93.60%.

:exclamation: Current head 3113847 differs from pull request most recent head fc62a41. Consider uploading reports for the commit fc62a41 to get more accurate results

Files Patch % Lines
packages/vite/src/utils.ts 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #669 +/- ## ======================================= Coverage 93.60% 93.60% ======================================= Files 32 32 Lines 1189 1189 Branches 189 189 ======================================= Hits 1113 1113 Misses 76 76 ``` | [Flag](https://app.codecov.io/gh/JonasKruckenberg/imagetools/pull/669/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jonas+Kruckenberg) | Coverage Δ | | |---|---|---| | [imagetools-core](https://app.codecov.io/gh/JonasKruckenberg/imagetools/pull/669/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jonas+Kruckenberg) | `97.01% <ø> (ø)` | | | [vite-imagetools](https://app.codecov.io/gh/JonasKruckenberg/imagetools/pull/669/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jonas+Kruckenberg) | `78.44% <0.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jonas+Kruckenberg#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

benmccann commented 10 months ago

@pzerelles is this PR still necessary if https://github.com/vitejs/vite/pull/15311 is merged?

pzerelles commented 10 months ago

@pzerelles is this PR still necessary if vitejs/vite#15311 is merged?

Yes