JonasKruckenberg / imagetools

Load and transform images using a toolbox :toolbox: of custom import directives!
MIT License
947 stars 59 forks source link

fix: filenames with spaces #670

Closed pzerelles closed 11 months ago

pzerelles commented 11 months ago
changeset-bot[bot] commented 11 months ago

🦋 Changeset detected

Latest commit: 708b404107f294f5648423c00ce3a2ee75c2a912

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | --------------- | ----- | | vite-imagetools | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov[bot] commented 11 months ago

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (fddbd1e) 93.60% compared to head (708b404) 93.24%.

Files Patch % Lines
packages/vite/src/index.ts 82.75% 5 Missing :warning:
packages/vite/src/utils.ts 78.57% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #670 +/- ## ========================================== - Coverage 93.60% 93.24% -0.37% ========================================== Files 32 32 Lines 1189 1228 +39 Branches 189 196 +7 ========================================== + Hits 1113 1145 +32 - Misses 76 83 +7 ``` | [Flag](https://app.codecov.io/gh/JonasKruckenberg/imagetools/pull/670/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jonas+Kruckenberg) | Coverage Δ | | |---|---|---| | [imagetools-core](https://app.codecov.io/gh/JonasKruckenberg/imagetools/pull/670/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jonas+Kruckenberg) | `97.01% <ø> (ø)` | | | [vite-imagetools](https://app.codecov.io/gh/JonasKruckenberg/imagetools/pull/670/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jonas+Kruckenberg) | `78.98% <81.39%> (+0.54%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jonas+Kruckenberg#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

benmccann commented 11 months ago

This includes the change to https://github.com/JonasKruckenberg/imagetools/pull/669, so we only need one

benmccann commented 11 months ago

I think we should probably not merge this workaround, but fix the underlying bug in Vite instead, which may be https://github.com/vitejs/vite/issues/15298

benmccann commented 11 months ago

Closing in favor of https://github.com/vitejs/vite/pull/15311