Closed pzerelles closed 11 months ago
Latest commit: 708b404107f294f5648423c00ce3a2ee75c2a912
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Attention: 8 lines
in your changes are missing coverage. Please review.
Comparison is base (
fddbd1e
) 93.60% compared to head (708b404
) 93.24%.
Files | Patch % | Lines |
---|---|---|
packages/vite/src/index.ts | 82.75% | 5 Missing :warning: |
packages/vite/src/utils.ts | 78.57% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This includes the change to https://github.com/JonasKruckenberg/imagetools/pull/669, so we only need one
I think we should probably not merge this workaround, but fix the underlying bug in Vite instead, which may be https://github.com/vitejs/vite/issues/15298
Closing in favor of https://github.com/vitejs/vite/pull/15311
Quick Checklist
[x] I have read the contributing guidelines
[ ] I have written new tests, as applicable (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[x] I have added a changeset, if applicable
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) This is a bug fix to support image filenames with special characters like spaces.
What is the new behavior (if this is a feature change)? Image asset filenames will not be URL-encoded on disk, only for rendering.
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?) I think no.
Other information: