Open happycollision opened 3 months ago
Latest commit: c9399520bf66607a1d52fb9a75d9f897e27a951b
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
I've discovered that the .withMetadata()
method keeps all metadata while allowing you to write to some of that metadata at the same time. This means it is incompatible with the removeMetadata
option. Looking into a different solution now...
Addresses #700 via an experimental setting.
🚨 I have not done everything on this list yet. I will do them, but I wanted to get some eyes on this draft first.
[x] I have read the contributing guidelines
[ ] I have written new tests, as applicable (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] I have added a changeset, if applicable 🚨🚨🚨 This PR needs a changeset. Just haven't done it yet.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
A new setting is added to both Vite config and as an option to pass into
applyTransforms
.This opt-in feature will pre-
rotate
/flip
/flop
an image based on the EXIF orientation data so that downstream developers can think about their images without first considering whether or not the image appearance is affected by metadata or by actual pixel locations. Two images that look the same might have completely different results when applyingflip
,flop
, orrotate
. If you takeremoveMetadata
into account, there are even more permutations to consider.This new setting removes the need to consider all these things.
I have attempted to test initial behavior and ensure that, unless you opt-in, that behavior is exactly the same. So no, there shouldn't be any breaking changes.