Closed dknibbe closed 4 months ago
Latest commit: ead219f3c557f706b957c0716746cc67e0312fca
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Attention: Patch coverage is 0%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 95.69%. Comparing base (
31c14f2
) to head (ead219f
). Report is 4 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
packages/vite/src/index.ts | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Quick Checklist
[x] I have read the contributing guidelines
[ ] I have written new tests, as applicable (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] I have added a changeset, if applicable
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) This change contains a bug fix for the feature introduced in pull request #690. The server origin option usually contains a protocol scheme identifier followed by a double slash, e.g. "http://localhost:1234". Nodes POSIX path implementation is not meant to join URLs, which means the double slash is converted to a single slash, resulting in an invalid URL, e.g "http:/localhost:1234". Using url-join instead ensures the result will be a valid URL.
Other information: Added new dependency: url-join, which seams to be the safest option