JonasNo / fauxbar

Automatically exported from code.google.com/p/fauxbar
0 stars 0 forks source link

Ctrl+D, Ctrl+L, and Ctrl+K result in Chrome error pages. #112

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Navigate to any web page (anything but the "new tab" page)
2. Press Ctrl+D, Ctrl+L, or Ctrl+K

What isthe expected output? What do you see instead?

I expect the Omnibox to get focus. Instead, I am taken to a Chromium error page 
with the following content:

"""
This webpage is not available
The webpage at chrome-extension://invalid/ might be temporarily down or it may 
have moved permanently to a new web address.
Error 2 (net::ERR_FAILED): Unknown error.
"""

Which version of Fauxbar and Chrome are you using, and which operating
system?

Fauxbar 1.2.8
Chromium 18.0.1025.162
Linux 3.3.2 64-bit

Original issue reported on code.google.com by drewfr...@gmail.com on 3 May 2012 at 4:59

GoogleCodeExporter commented 9 years ago
I just updated to Chromium 18.0.1025.168 and the issue is still present.

Original comment by drewfr...@gmail.com on 3 May 2012 at 6:03

GoogleCodeExporter commented 9 years ago
Update: this error occurs for me roughly 80% of the time, and I can't figure 
out what might be different when it does work. A friend told me he sees the 
same error, but less often: ~20% of the time. I'm not sure if this is a Fauxbar 
bug or a Chrome bug.

Original comment by drewfr...@gmail.com on 12 May 2012 at 12:13

GoogleCodeExporter commented 9 years ago
The same here, about 80% of time.

Original comment by prma...@gmail.com on 15 May 2012 at 10:24

GoogleCodeExporter commented 9 years ago
Un-installing and re-installing seems to have addressed the issue, at least for 
the moment.

Original comment by gearoid....@gmail.com on 19 May 2012 at 2:10

GoogleCodeExporter commented 9 years ago
Didn't help there. Still the same.

Original comment by prma...@gmail.com on 19 May 2012 at 2:17

GoogleCodeExporter commented 9 years ago
I'm seeing this too sometimes.

Original comment by fauxbar....@gmail.com on 3 Jun 2012 at 11:25

GoogleCodeExporter commented 9 years ago
Looks like a Content Security Policy issue.

Error is:
    Denying load of chrome-extension://imgfofnmolhfkmefgkfohhpgoeahgoil/html/fauxbar.html#sel=ai&ai=http%3A%2F%2F127.0.0.1%2F. Resources must be listed in the web_accessible_resources manifest key in order to be loaded by web pages.

alt-d.js uses this crude method:
    window.location = chrome.extension.getURL("/html/fauxbar.html#sel=ai&ai="+window.urlencode(window.location.href));

I'll probably need to send a message request to the background page instead, 
and let Fauxbar's background script update the tab's URL.

Original comment by fauxbar....@gmail.com on 4 Jun 2012 at 1:53

GoogleCodeExporter commented 9 years ago
Ah, adding this to Fauxbar's manifest fixes the problem:

    "web_accessible_resources": [
        "html/fauxbar.html"
    ]

Will try and get this out today for v1.2.9.

Original comment by fauxbar....@gmail.com on 4 Jun 2012 at 2:15

GoogleCodeExporter commented 9 years ago
I just modified manifest.json as suggested and it didn't fix the problem for me.

Original comment by drewfr...@gmail.com on 4 Jun 2012 at 2:53

GoogleCodeExporter commented 9 years ago
drewfrank, can you please try this test version attached? (disable your 
existing Fauxbar first, then drag the CRX file into Chrome)

I've also edited background.js; alt-d.js was getting injected twice instead of 
once.

Original comment by fauxbar....@gmail.com on 4 Jun 2012 at 3:05

Attachments:

GoogleCodeExporter commented 9 years ago
Seems fixed. Thanks!

Original comment by drewfr...@gmail.com on 4 Jun 2012 at 3:28

GoogleCodeExporter commented 9 years ago
Cool. Fixed in v1.2.9, just released.

Original comment by fauxbar....@gmail.com on 4 Jun 2012 at 5:13