search

JonasPammer / cookiecutter-ansible-role

An awesome CookieCutter for my ansible roles.
MIT License
1 stars 3 forks source link

refactor: remove use of workaround for dynamic cookiecutter variable #39

Closed JonasPammer closed 2 years ago

JonasPammer commented 2 years ago

...instead of 'adhoc' way made in https://github.com/JonasPammer/cookiecutter-ansible-role/commit/27809eabeebb952ee685cb30f1f80bf38f0d74af (which i in turn originally found in https://github.com/cookiecutter/cookiecutter/issues/1115#issuecomment-714611568) because this gives errors for cookiecutter 2.1.0 (in detail because of https://github.com/cookiecutter/cookiecutter/pull/1496)

when i made said commit i did not yet have knowledge if hooks work with cruft so i preferred it this way. i recently made an adhoc test and saw they get executed, at least on first commit and at least post hook which is what i tested. i hope pre hook too, because i'd assume this is the one that i need to use in a potential PR for this here. but its midnight so the PR is far away and i've temporarily avoided it for my current need of executing maintenance scripts of by changing pin to <2.1 in https://github.com/JonasPammer/ansible-roles/commit/63d745a41b7c26f507e0f02ea446c1673f4ee694 ;););)

JonasPammer commented 2 years ago

double undescore Private Variables seem to now (apparentely since June) have finally been released and be working as I just found out by scrolling the linked cookiecutter issue 1115 comments. meaning hooks are not even required for refactoring out this workaround. awesome, changed the title.