search

JonasProgrammer / docker-machine-driver-hetzner

Docker machine driver for the new hetzner cloud API
https://jonasprogrammer.github.io/docker-machine-driver-hetzner/
MIT License
434 stars 54 forks source link

update dependency hcloud-go to v2.2.0 #113

Closed ghost closed 1 year ago

ghost commented 1 year ago

Related Issue: #112 Reason: https://status.hetzner.com/incident/21307528-ede6-4a43-8641-3fdd6fbb03fe

JonasProgrammer commented 1 year ago

Hi,

thank you fro raising the issue and getting this PR filed! Given that I mostly run on Hetzner metal nowadays I'd probably have missed this.

Skimming over the diff in hcloud-go, I'm not entirely convinced this alone is sufficient to fix the issue. The legacy 'unscoped' actions client is still exposed, but will use the now-deprecated endpoint from what I get. Also I'm not 100% sure whether the plain /actions will be gone for good (i.e. including /actions/{id}) or whether it's just the global listing. What baffles me is that https://docs.hetzner.cloud/changelog is still eerily quiet about this.

Anyways, I'm gonna merge the PR this weekend. I just want to have a look in a debugger what actually goes over the wire towards Hetzner. If aforementioned suspicion is correct, I've got to bite the bullet and migrate to a wait implementation per resource type.

ghost commented 1 year ago

Thank you! I was also suprised that it's only a "information" popup in the account and not in the changelog. Maybe it was overlooked because obviously someone informed some system with this update.