Set networks and serverLabels as public fields

JonasProgrammer / docker-machine-driver-hetzner

Docker machine driver for the new hetzner cloud API

https://jonasprogrammer.github.io/docker-machine-driver-hetzner/

MIT License

431 stars 53 forks source link

Set networks and serverLabels as public fields #64

Closed jmatsushita closed 3 years ago

jmatsushita commented 3 years ago

Hi there,

A couple of issues in the terraform-rancher2-provider would be able to move forward if the following fields where marked as public so that they can be marshalled/unmarshalled:

If there aren't any reason for the other fields to be private I would also suggest exporting:

userData
volumes
firewalls
additionalKeys

Happy to submit a PR if you agree with the intent here.

Thanks,

Jun

jmatsushita commented 3 years ago

To clarify, this would be used in the following way by the terraform provider https://registry.terraform.io/providers/rancher/rancher2/latest/docs/resources/node_template#hetzner_config

JonasProgrammer commented 3 years ago

Hi,

I've implemented the requested changes on a feature branch for now. Could you please try out the artifacts here and see if they fit your needs?

I have added the other requested items as well, except the user-data. IMO this field is more likely to contain secret information than the others, so I personally would prefer to keep it only when needed -- i.e. during the creation. I'm open for discussion, however.

Cheers

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.