Instantiation does not properly log an error if edgegridrc `path` is falsey.

JonathanBennett / AkamaiOPEN-edgegrid-node

MIT License

7 stars 45 forks source link

Instantiation does not properly log an error if edgegridrc `path` is falsey. #9

Closed mdb closed 9 years ago

mdb commented 9 years ago

In current implementation, AkamaiOPEN-edgegrid-node explicitly checks for an undefined path.

However, it is my belief that this is inadequate, as the path could also be an empty string, a boolean, or a non-string value. In my mind, simply checking for !path is preferable.

I am working on a PR/tests addressing this issue. See my edgerc-cleanup branch for further details.

Thanks!

mdb commented 9 years ago

I believe this issue can be closed as of PR #12.

JonathanBennett commented 9 years ago

Thanks @mdb