search

JonathanDMefford / weather-app

https://jonathandmefford.github.io/weather-app/
0 stars 0 forks source link

Weather App Critical Feedback Ian Rios #1

Open ianrios opened 4 years ago

ianrios commented 4 years ago
  1. Too many temporary variables
  2. Follow naming conventions
  3. Save time on multiple of the same document.getElementById() calls by setting their results to variables.
  4. Don't use .style.attribute, use bootstrap classes instead
  5. CSS file overwrites bootstrap classes; remove the custom css and use bootstrap instead (I know you had very specific css, but it should still work, ask me if you can't get it)