JonathanDn / vue-stars-rating

A highly dynamic vue stars rating component, similar to google play stars rating
103 stars 18 forks source link

Change calculation of circles radius #15

Open thesteffi opened 3 years ago

thesteffi commented 3 years ago

Hey :)

I am using your star in a project of mine (a Google DataStudio vis - can drop you the link if interested in that) and there I noticed the "funny" Behaviour that the stars don't constrain to the boxes they should fit in if you're going crazy with the chubbiness (or rather skinniness).

This proposal fixes this by creating a circle that exactly fits into the rectangle that the star should fit into and then calculates the inner circle based on the ratio and the outer circle. You did the other way around.

cheers Stefanie