search

JonathanGarro / SIMS-Portal

IFRC Surge Information Management Support Portal
3 stars 4 forks source link

Unicode error in Acronyms CSV export #106

Closed ioalexei closed 6 months ago

ioalexei commented 6 months ago

ALA acronym shows correctly as Åland Islands in the table on the website but shows as Ã…land Islands in the CSV export

From a quick scan also affects: BCG, BLM, CHAST, CIV - and probably some others

JonathanGarro commented 6 months ago

thanks @ioalexei i will dig into this

ioalexei commented 6 months ago

Update on this - with the new functionality from #107 the CSV download now has lots of extra text in the first column - e.g. 

Acronym (English)
----------------
AAP                                                                                                  Acronym Details                                                                                                                                English                         AAP                                                                                                                                                                                     Definition                         Accountability to Affected Populations                                                                                                                                                                                                                                                                                                                                                                                     Permalink                                                                                        Close
ioalexei commented 6 months ago

One more thought on this - at the moment the CSV downloads as SIMS.csv. Could it be something like SIMS-acronyms.csv ?

JonathanGarro commented 6 months ago

yikes, didn't notice the export mess. i'll dig into that as part of this issue

JonathanGarro commented 6 months ago

@ioalexei I've rebuilt the JS that loads that CSV and pushed it up to prod. Can you take a look and let me know if that solves the data export issue you saw? I also changed the default name of the generated file.

I still need to solve the encoding issue.

ioalexei commented 6 months ago

@JonathanGarro thanks - looks fixed now, and downloads with the new file name.

JonathanGarro commented 6 months ago

great. ive also fixed the utf-8 encoding issue, will appear in the 1.9.2 release.