DialogsDemo Update - Githubissues

JonathanGiles / fx-ui-controls

Sample app intended to introduce basic use cases for all JavaFX UI controls that ship in the core distribution

MIT License

25 stars 8 forks source link

DialogsDemo Update #18

Closed AlmasB closed 6 years ago

AlmasB commented 6 years ago

[X] VBox: same width buttons, 5px spacing
[X] Text in each dialog for demo
[X] Custom result converter, UsernamePassword
[X] showAndWait()

JonathanGiles commented 6 years ago

Did you want me to merge now or wait? Thanks!

AlmasB commented 6 years ago

I'd say keep the PR open for now, I'll let you know when the remaining TODO is done. Cheers

AlmasB commented 6 years ago

@JonathanGiles all done, ready for review

JonathanGiles commented 6 years ago

Thanks. Very nice. I pushed some minor tweaks. If you have bandwidth, a demo with Spinner would be appreciated (again, HelloSpinner from OpenJFX can help here).