search

JonathanGiles / scenic-view

Scenic View is a JavaFX application designed to make it simple to understand the current state of your application scenegraph, and to also easily manipulate properties of the scenegraph without having to keep editing your code. This lets you find bugs, and get things pixel perfect without having to do the compile-check-compile dance.
GNU General Public License v3.0
523 stars 68 forks source link

Update to openjfx19 and jdk17 and gradle 6.7 #76

Closed Siedlerchr closed 8 months ago

Siedlerchr commented 1 year ago

Fixes #75 Fixes #70

Superseeds #64

credmond commented 11 months ago

Thanks for this @Siedlerchr. A shame nobody will merge your PR.

Have you noticed less bugs with your newer build?

Siedlerchr commented 11 months ago

TBH I haven't used Scene Builder in ages. At least not recently after I made this PR.

I need to compile it locally because the mac binaries are not signed/ nor notarized. And because the gradle version was no outdated, I could event get it compiled with a newer version of Java

A shame nobody will merge your PR.

Yes, that's what sucks here with the whole javafx ecosystem. The say, look there are cool open source libraries babla however, most of them are horrible outdated and nobody even cares about PRs coming in. That sucks the most.

credmond commented 11 months ago

TBH I haven't used Scene Builder in ages. At least not recently after I made this PR.

Well it works much better with your build. I had thought that it was just a rubbish buggy tool (couldn't understand why people said it was "essential"). I didn't think it was just JDK incompatibilities.

Yes, that's what sucks here with the whole javafx ecosystem. The say, look there are cool open source libraries babla however, most of them are horrible outdated and nobody even cares about PRs coming in. That sucks the most.

Yep -- I am coming back to JavaFX after 2014 (when I thought it was great). Back then I never used SceneBuilder or ScenicView (probably when they actually worked with minimal bugs).

I was shocked/saddended to see the state of the ecosystem. Everything was just broken: tools, documentation, links. Releasing new major versions of something with practically no fixes/improvements, and marketing them. Every JavaFX ecosystem repo has hundreds of ignored issues and PRs -- some fixing critical issues -- just sitting there. Very sad. They're all controlled by the same seemingly absent folks. I won't mention names / companies, but you know who/what I mean.

I know they're just understaffed and not making money from these libs, it's not their fault, they can't do everything. I just think the projects aren't really open source if nobody can contribute in a timely manner.

I personally am hesitant to spend any time fixing anything sizeable because I know a PR will sit there ignored for 3 years.

Maybe we should fork and publish our own packages -- very easy / free using Github Packages. Don't even need to sign them.

JonathanGiles commented 8 months ago

This should be fixed by #78 that was just merged.