search

JonathanGiles / scenic-view

Scenic View is a JavaFX application designed to make it simple to understand the current state of your application scenegraph, and to also easily manipulate properties of the scenegraph without having to keep editing your code. This lets you find bugs, and get things pixel perfect without having to do the compile-check-compile dance.
GNU General Public License v3.0
523 stars 68 forks source link

Event tracing fails because of missing modules open #81

Open credmond opened 7 months ago

credmond commented 7 months ago 
Caused by: java.lang.IllegalAccessException: module javafx.base cannot access class org.scenicview.view.tabs.EventLogTab$ScenicViewEvent (in module org.scenicview.scenicview) because module org.scenicview.scenicview does not open org.scenicview.view.tabs to javafx.base
        at javafx.base@21.0.1/com.sun.javafx.property.MethodHelper.invoke(Unknown Source)
        ... 57 more

I think ScenicView is missing other "opens" too for itself (org.scenicview.view.xxx) -- I recall some stacktraces in the past.

For a standalone UI like this, I don't really see the point in worrying about individual opens -- just use a global open module, especially since there doesn't appear to be any tests to find these types of issues.

credmond commented 7 months ago

Fixed in this PR: https://github.com/JonathanGiles/scenic-view/pull/82