search

JonathanGuberman / unmatched_maker

A deck maker tool for Unmatched
https://jonathanguberman.github.io/unmatched_maker/
10 stars 2 forks source link

Add sensible limits to the UI for image download #43

Closed JonathanGuberman closed 3 years ago

JonathanGuberman commented 3 years ago

I'm calling this one a bug, because the limits exist, the interface just doesn't give any indication about it to the user.

Right now the API just downsizes requests that are too large silently, but it should probably error out instead.

And what about decks with, say, 1000 cards? That would be bad. 🤔

JonathanGuberman commented 3 years ago

I added some limits here, so it's not completely crazy, but I'm going to leave this open for now because it could be better.

JonathanGuberman commented 3 years ago

Changed my mind, closing after all.