JonathanKhooTY / pe

0 stars 0 forks source link

Adding price into menu into store accepts negative integer #11

Open JonathanKhooTY opened 3 years ago

JonathanKhooTY commented 3 years ago

Software accepted "-10" as a valid price when trying to add menu to store. First picture is the view from Admin. 2nd picture is view as public user.

image.png

image.png

nus-pe-bot commented 3 years ago

Team's Response

No response provided.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Adding of menu with negative price

Negative values can be entered for pricing of menu.

Screenshot (61).png


[original: nus-cs2113-AY2021S2/pe-interim#1396] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

No response provided.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: This shouldn't be a feature flaw, since in no instance/version of the software, should a negative price value ever be accepted.


:question: Issue severity

Team chose [severity.Low] Originally [severity.High]

Reason for disagreement: I believe severity should remain as high since the whole purpose of this software is to advise the user on food pricing. Having a negative price value essentially renders this software unreliable for it's users, especially since it is a flaw that affects most users and causes major problems for users. i.e., makes the product almost unusable for most users.