JonathanOrr / A321Neo-FXPL

The A32NX Project, a A321NEO freeware for the X-Plane community
GNU General Public License v3.0
165 stars 70 forks source link

add park brake/autobrake support required by Airbus TCA switch/button… #51

Closed stgrosshh closed 3 years ago

stgrosshh commented 3 years ago

Proposal for changes required to support Thrustmaster Airbus TCA quadrant add on. The autobrake settings hardware is implemented with a dial switch with discrete positions and not as a toggle. Thererfore a different logic triggered by the new commands seems to be required. Also the park break of the quadrant is implemented as a kind of push button and not two discrete switches or a toggle.

rico23rico commented 3 years ago

@stgrosshh

What's the point of having custom commands if you call the same functions?


sasl.registerCommandHandler (Toggle_lo_autobrake, 0, function(phase) Toggle_autobrake(phase, AUTOBRK_LOW)  end)
sasl.registerCommandHandler (Toggle_med_autobrake, 0, function(phase) Toggle_autobrake(phase, AUTOBRK_MED) end)
sasl.registerCommandHandler (Toggle_max_autobrake, 0, function(phase) Toggle_autobrake(phase, AUTOBRK_MAX) end)

vs

sasl.registerCommandHandler (TCA_lo_autobrake, 0, function(phase) Toggle_autobrake(phase, AUTOBRK_LOW) end)
sasl.registerCommandHandler (TCA_med_autobrake, 0, function(phase) Toggle_autobrake(phase, AUTOBRK_MED) end)
sasl.registerCommandHandler (TCA_max_autobrake, 0, function(phase) Toggle_autobrake(phase, AUTOBRK_MAX) end)
stgrosshh commented 3 years ago

You're absolutely right. Will remove this part, which was leftover from a first approach.