added param getters/setters to all Layer classes for consistency

JonathanRaiman / theano_lstm

:microscope: Nano size Theano LSTM module

Other

304 stars 111 forks source link

added param getters/setters to all Layer classes for consistency #6

Closed mheilman closed 9 years ago

mheilman commented 9 years ago

I think this functionality for saving and loading models should actually work now, in a consistent manner, for all the Layer classes. I made these additional changes after having trouble saving a model with an Embedding layer. Sorry about issuing the premature PRs #4 and #5. I'm still figuring out theano.

JonathanRaiman commented 9 years ago

Of course. That's great. Also, you know that you can turn off re-optimizing Theano's graph ? If you pickle a model you made with Theano functions, then use :

    theano.config.reoptimize_unpickled_function = False
    theano.gof.compilelock.set_lock_status(False)

And unpickle your saved model, then it'll take much much less long to compile the functions.

mheilman commented 9 years ago

Nice! Thanks for the tip.