JonathanReeve / data-ethics-literature-review

An automated survey of literature and curricula surrounding ethics in data science. WIP.
http://data-ethics.tech
GNU General Public License v3.0
1 stars 1 forks source link

Serena branch for metadata from ArXiv #33

Open sy2657 opened 3 years ago

sy2657 commented 3 years ago

Adding functions for querying Arxiv: main_arxiv.py, editRatio.py, extractalphanumeric.py, queryArxiv.py, and jupyter notebook query_arxiv_metadata.

netlify[bot] commented 3 years ago

❌ Deploy Preview for data-ethics-tech failed.

🔨 Explore the source changes: 074e20ffb587d06efa5c81574d34c8f6b393cc2d

🔍 Inspect the deploy log: https://app.netlify.com/sites/data-ethics-tech/deploys/612302ee96b8150008b92403

JonathanReeve commented 3 years ago

Serena, thanks for this. But could you fix these things?

sy2657 commented 3 years ago

Ok I will try. I think I did write more specific commit messages, but somehow it printed the commit messages I made weeks ago.

On Fri, Jul 23, 2021 at 6:13 PM Jonathan Reeve @.***> wrote:

Serena, thanks for this. But could you fix these things?

  • Rename this pull request from "Serena branch" to something semantic, which describes what it is you're doing in this pull request.
  • Put text files containing bibliographies in the data/texts/txt directory
  • Use .py files instead of .ipynb
  • Remove all .ipynb_checkpoints files
  • Make separate pull requests for separate issues, i.e. one pull request for bibliographic text files, and another pull request for arXiv interfacing
  • Write commit messages that say what you're doing. You say "add files via upload," but you need to say what it is you're doing in that commit, and make it semantic. Maybe have a look through some of the tutorials on how to write a commit message. https://duckduckgo.com/?q=how+to+write+a+good+git+commit+message&ia=web

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/JonathanReeve/data-ethics-literature-review/pull/33#issuecomment-885980577, or unsubscribe https://github.com/notifications/unsubscribe-auth/AONNUEJ2NMIZLVATHL6LUL3TZIHUZANCNFSM5A4S4JZA .