Open CathyHajo opened 10 years ago
We tagged the titles as "title type="journal" or "title type="book" but in the header these are turned into links, which don't go anywhere. The links that we encoded are working fine. Not good because it makes the site look very broken.
Example: http://www.nyu.edu/projects/sanger/webedition/app/documents/show.php?sangerDoc=321968.xml
Example with working and broken links <a rel="noreferrer nofollow" target="_blank" href="http://www.nyu.edu/projects/sanger/webedition/app/documents/show.php?sangerDoc=320986.xml">http://www.nyu.edu/projects/sanger/webedition/app/documents/show.php?sangerDoc=320986.xml</a></p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/JonathanReeve"><img src="https://avatars.githubusercontent.com/u/1843676?v=4" />JonathanReeve</a> commented <strong> 9 years ago</strong> </div> <div class="markdown-body"> <p>So, as I understand it, <code>title type="journal"</code> works, since it queries for <code>search.php?journal="some-journal"</code>, but it thinks <code>title type="book"</code> is also a journal, so it tries <code>search.php?journal="a-book"</code>, which doesn't work, since the book isn't in the list of journals. Does that sound right? If so, I think what needs to be done here is to edit the XSL so that it better understands the difference between the two title types. </p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>
We tagged the titles as "title type="journal" or "title type="book" but in the header these are turned into links, which don't go anywhere. The links that we encoded are working fine. Not good because it makes the site look very broken.
Example: http://www.nyu.edu/projects/sanger/webedition/app/documents/show.php?sangerDoc=321968.xml
Example with working and broken links
<a rel="noreferrer nofollow" target="_blank" href="http://www.nyu.edu/projects/sanger/webedition/app/documents/show.php?sangerDoc=320986.xml">http://www.nyu.edu/projects/sanger/webedition/app/documents/show.php?sangerDoc=320986.xml</a></p> </div>
</div>
<div class="comment">
<div class="user">
<a rel="noreferrer nofollow" target="_blank" href="https://github.com/JonathanReeve"><img src="https://avatars.githubusercontent.com/u/1843676?v=4" />JonathanReeve</a>
commented
<strong> 9 years ago</strong> </div>
<div class="markdown-body">
<p>So, as I understand it, <code>title type="journal"</code> works, since it queries for <code>search.php?journal="some-journal"</code>, but it thinks <code>title type="book"</code> is also a journal, so it tries <code>search.php?journal="a-book"</code>, which doesn't work, since the book isn't in the list of journals. Does that sound right? If so, I think what needs to be done here is to edit the XSL so that it better understands the difference between the two title types. </p> </div>
</div>
<div class="page-bar-simple">
</div>
<div class="footer">
<ul class="body">
<li>© <script>
document.write(new Date().getFullYear())
</script> Githubissues.</li>
<li>Githubissues is a development platform for aggregating issues.</li>
</ul>
</div>
<script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script>
<script src="/githubissues/assets/js.js"></script>
<script src="/githubissues/assets/markdown.js"></script>
<script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script>
<script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script>
<script>
hljs.highlightAll();
</script>
</body>
</html>