Closed jordan9001 closed 2 days ago
It looks like AARCH64's getParentRegisters()
lists the d#
registers but not the q#
registers. So, if it makes sense I could replace those as well.
Thx for this report. Indeed, it would make more sense. Sounds good to me :)
@JonathanSalwan Is there a specific reason some flag registers are their own parent? Or is it okay if I have ZF's parent be EFLAGS and EFER_TCE's parent be EFER?
The
getParentRegisters()
function for x86_64 returns some duplicate registers, specificallyisSSM
,isAVX256
isAVX512
are all included. I am happy to submit a pull request, but I was would like your feedback first. It makes sense to me that the only parent registers listed on x86 should be the YMM registers, none of theisSSM
registers. On x86_64 it should just be the zmm registers. Do you agree?Essentially, I would like to add this test to the tests:
I would probably also add and use a
isAVX512Parent
function, because theisAVX512
function returns some xmm and ymm identifiers as well.