Closed adamgayoso closed 5 years ago
The new package structure was tested. Everything imports fine.
Why should this not go into 3.0?
Why should this not go into 3.0?
This doesn't change the API, but really just adds documentation. The documentation is relevant now, as opposed to when 3.0 comes out.
By the way, we can squash this into master.
Also, I'm not familiar with sphinx, so I'm assuming your design is reasonable re: Makefile etc. Being self contained within the docs folder seems good.
Sphinx pretty much automates this.
Restructures package in a more sensible way
setup.py
so they get installed automaticallyphenograph
has to be manually installed (it basically was before wrapped in requirements.txt)phenograph
is not installed, anImportError
is raised with install instructions.Note that
phenograph
will become optional in v3.0 so this is a fine temporary solution.