search

JonathanShor / DoubletDetection

Doublet detection in single-cell RNA-seq data.
https://doubletdetection.readthedocs.io/en/stable/
MIT License
87 stars 23 forks source link

Conform to sklearn estimator API #61

Closed JonathanShor closed 6 years ago

JonathanShor commented 6 years ago

Changes required include, at least:

  1. .fit(X) returns the class instance, not the labels, to allow chained calls (clf.fit(X).predict(X)).
  2. Add .predict(X).
  3. Add .predict_proba(X). 3a. Not sure that we need .predict_log_proba(X)
adamgayoso commented 6 years ago

What will .predict_proba(X) return? The voting average or all p-values?

adamgayoso commented 6 years ago

I also see a number of issues with the docstring, but I'm assuming we will update those with the 2.0 release.