search

JonathanTreffler / backblaze-personal-wine-container

Run the Backblaze personal backup client in a docker container
https://hub.docker.com/r/tessypowder/backblaze-personal-wine
GNU Affero General Public License v3.0
374 stars 35 forks source link

Make startapp log file location configurable by an env var #129

Closed brokeh closed 6 months ago

brokeh commented 6 months ago

So that it is not included in the pushed backups

traktuner commented 6 months ago

Hey, thanks for the PR! I'll look into that, but currently, I see that as an added benefit for troubleshooting backup issues (last pushed entry in the log, modification time etc)

brokeh commented 6 months ago

No worries. If there's utility in that behaviour then I can change it to be configurable via an env var then. Does that sound OK?

traktuner commented 6 months ago

No worries. If there's utility in that behaviour then I can change it to be configurable via an env var then. Does that sound OK?

We ask people to provide this logfile to see why there may be an issue with the app not starting/installing, etc and therefore we need a defined path to the logfile and that path should not change. I think it's best to add the file to the exception list in Backblaze so that it's not backed up. I put it in the root of C: intentionally that it's not dependent on any wine installation or initialization.

brokeh commented 6 months ago

I have no issues with myself (and presumably most others who explicitly set an environment variable) opening a shell into the Docker container and grabbing the log files out from the backend if necessary.

As for excluding it in the Backblaze config, as far as I can tell this is not possible under the current setup. It is only possible to exclude folders and file extensions. Since this is put straight into the root of C:\ it is not possible to exclude it by folder and I do want *.log files as there are some log files in other locations I do want backed up.

Andrew-Brock commented 6 months ago

Not sure why the CI is filing on this. Doesn't seem like anything related to the change

traktuner commented 6 months ago

Not sure why the CI is filing on this. Doesn't seem like anything related to the change

yes, that's ecxpected.