Closed davidslater closed 1 year ago
Hey David.
Can you make a PR with your suggested change number 2 (and add tabulate dependency to requirements.txt but not minimum_requirements.txt), so I can simply review and accept the PR? (not easy for me to make these changes myself at the moment).
If you're free to do this right now, can be sorted very quick :)
Also thanks!
Yes, can do.
Done
Please add
tabulate
to the dependencies inrequirements.txt
andminimum_requirements.txt
. Currently, if you import the library, you get a ModuleNotFoundError fortabulate
. This in turn effects all imports of functions from the library.Here is the stack trace:
Alternatively, if you didn't want to modify the minimum_requirements, you will need to do one of the following (or something similar). The second solution would provide backwards compatibility and is my recommendation:
datasets
in./trackeval/__init__.py
. Not sure what issues this would cause elsewhere in the library../trackeval/datasets/__init__.py
, you can add a try / except block to catch this issue as follows. You can change these lines:to