Layer blocks don't copy correctly when using the wand

[mkern1200]

Hello! Firstly, thank you for porting this mod to Fabric! I much prefer it to Building Wands for its simplicity and user-friendliness, but didn't have any good alternatives before now, so I appreciate your efforts!

That said, I've recently discovered a minor bug. When using the wand with the construction core on a layered block, such as snow layers, it will only place a row of single-layer blocks rather than matching the layer level of the adjacent blocks (i.e. right-click on the side of a block with 5 snow layers, and only 1 snow layer will be placed). We are also using the mods Create and Create: Copycats+, which seems to experience the same issue (although I don't know how similar the copycat layers are to vanilla layers from a mechanics perspective).

If you need anything else to help with this, I'm more than happy to provide whatever assistance I can!

(Using version 1.0.2 of Construction Wand Fabric on Minecraft 1.20.1)

[JongWasTaken]

Hello, and thank you for creating an issue!

I just checked, and this seems to also be the case with the original Forge mod (at least with snow layers).
Since this port reuses much of the original code, quirks like these tend to be transferred over as well.

I have now added support for layered blocks in version 1.0.3, which I have attached to this message (I had to zip it for GitHub to allow it).

Could you please try this version out and test if it also works the Create blocks?

Thank you and have a great day.

constructionwand-1.0.3+1.20.1.zip

[mkern1200]

Thanks for the quick work! This definitely seems to fix the issue with the layers, but I am noticing a similar bug with other blocks. There are some blocks, like slabs in vanilla Minecraft, as well as many of the copycat blocks in Create: Copycats+, that can have multiple "pieces" within the same block space (e.g. two slabs within the same block). It appears that even though the layers are working correctly now, trying to use the wand to expand rows of these blocks will copy some of the pieces but not others, seemingly at random.

Also (and I'm sorry to be a bother with this, I'm sure copycats are the archnemesis of a mod like this), textures... copycat blocks are functionally similar to framed blocks, if you're familiar with those. Essentially, copycats have an "empty" texture which you can right-click with any solid block, and it will "store" the block applied within the copycat and take on its texture. This allows players to use block textures on shapes that otherwise wouldn't exist, such as a working door with the texture of stone or a diagonal slope of glass. Two functions happen when a copycat is right-clicked with a solid block: it will (a) consume the block, which is returned when the texture is manually removed or the copycat is broken, and (b) it will take on the texture of the solid block, modified to the shape of the copycat.

While the construction wand in this mod is able to place copycat blocks, but only as the empty default texture. It would be nice if the copycats that already have textures applied could be copied with their textures if the player has the blocks in their inventory to consume for those textures. I have no idea if something like this would even be possible, but I figure there's no harm in asking. Thanks again!

[JongWasTaken]

So the slab thing was apparently on purpose by the original developer, because they encountered duping issues. I just rewrote that to behave similarly to layered blocks, and it looks like that works well.

Now the copycats, those are a little bit more complicated.
I am currently investigating if adding support for them is feasible, but don't count on it.

Either way, I think I will release version 1.3.0 with support for layers and slabs sometime later today, just so that is out of the way. I am little busy today, so maybe it will be tomorrow instead.

Once again, thank you for your cooperation!

[JongWasTaken]

Hello once again!

I've been working on this on-and-off for the past few days, and I think I got it working quite well, albeit with some caveats:

• Most copycats work as expected, but some of the more complicated ones (shafts, catwalks, slabs for some reason) will not, because they are implemented differently and I couldn't figure out how to correctly interact with them.
• I had to rework some internal stuff to allow for blocks with multiple items (e.g. a copycat with a block attached to it), which might have added a possible item dupe somewhere, though I did pay special attention to that not happening. Still, it is possible.

If you are still interested in this, I would appreciate you testing this release before I make it public on the usual websites. As before, it is attached to this comment as a zip file.

Have a good day!

constructionwand-1.0.4+1.20.1.zip

[mkern1200]

Thanks for following up! I was testing it, and from what I can tell, everything seems to be copying correctly with the construction wand. I'm not able to figure out how to use the "blocks with multiple items" feature you mentioned, not sure if I'm doing something wrong. It still copies the copycat blocks when they're textured, but just the blank texture without the block it was meant to have applied. The number of blocks consumed is still accurate to what's being placed as far as I can determine.