search

JongWasTaken / moretools

A simple, server-side mod which adds hammers and excavators.
https://modrinth.com/mod/more-tools
MIT License
1 stars 3 forks source link

Tools block breaking speed seems kinda off #10

Closed noiverre closed 2 months ago

noiverre commented 2 months ago

Bug: When using Iron Saw with Efficiency IV, a player noticed that it could break stones quickly like how Pickaxes are supposed to work. Then I tested with Diamond Excavator and Diamond Saw with Efficiency V on stones, the block breaking speed is nearly as fast as Diamond Pickaxe with Efficiency V, only slightly slower, like Efficiency 4

Expected behavior: Each More Tools tools can only be the best tool to break the corresponding blocks according to the recipe material, so an Excavator should be effective against dirt, sand, etc like how shovel is, Hammers and Vein Hammers should be related to stones, etc

noiverre commented 2 months ago

Mod list 

[14:51:20] [main/INFO]: Loading 214 mods:
    - alchemist 1.1.3
       \-- playerabilitylib 1.10.0
    - alternate-current 1.8.0
    - amplified_nether 1.2.5
    - antixray 1.4.4
       \-- com_moandjiezana_toml_toml4j 0.7.2
    - anvilrestoration 2.3
    - brainierbees 1.6
    - brewery 0.8.0+1.21-rc1
       |-- net_objecthunter_exp4j 0.4.8
       |-- server_translations_api 2.3.1+1.21-pre2
       \-- sgui 1.6.0+1.21
    - camp_fires_cook_mobs 1.3.0
    - cavespiderspawn 1.2
    - collective 7.81
    - constructionwand 1.0.5
       |-- forgeconfigapiport 21.0.0
       |-- polymer-core 0.9.9+1.21
       |    |-- polymer-networking 0.9.9+1.21
       |    |    \-- polymer-common 0.9.9+1.21
       |    |         \-- packet_tweaker 0.5.5+1.21
       |    \-- polymer-registry-sync-manipulator 0.9.9+1.21
       |-- polymer-resource-pack 0.9.9+1.21
       |    \-- polymer-common 0.9.9+1.21
       |         \-- packet_tweaker 0.5.5+1.21
       \-- sgui 1.6.0+1.21
    - craft-chain-armor 1.0.0_1.21
    - crashexploitfixer 1.1.0
    - creeperhealing 1.2.1-1.21+
    - diversity 1.3.2+1.21
       |-- fabric-permissions-api-v0 0.3.1
       |-- midnightlib 1.5.7
       |-- org_reflections_reflections 0.10.2
       \-- polymer-core 0.9.9+1.21
            |-- polymer-networking 0.9.9+1.21
            |    \-- polymer-common 0.9.9+1.21
            |         \-- packet_tweaker 0.5.5+1.21
            \-- polymer-registry-sync-manipulator 0.9.9+1.21
    - doubledoors 5.9
    - edibles 4.4
    - emi 1.1.11+1.21+fabric
    - fabric-api 0.102.0+1.21
       |-- fabric-api-base 0.4.42+6573ed8cd1
       |-- fabric-api-lookup-api-v1 1.6.68+b5597344d1
       |-- fabric-biome-api-v1 13.0.29+5bd9f1bcd1
       |-- fabric-block-api-v1 1.0.22+0af3f5a7d1
       |-- fabric-block-view-api-v2 1.0.10+6573ed8cd1
       |-- fabric-blockrenderlayer-v1 1.1.52+0af3f5a7d1
       |-- fabric-client-tags-api-v1 1.1.15+6573ed8cd1
       |-- fabric-command-api-v1 1.2.49+f71b366fd1
       |-- fabric-command-api-v2 2.2.28+6ced4dd9d1
       |-- fabric-commands-v0 0.2.66+df3654b3d1
       |-- fabric-content-registries-v0 8.0.16+b5597344d1
       |-- fabric-convention-tags-v1 2.0.19+7f945d5bd1
       |-- fabric-convention-tags-v2 2.5.0+c5e2b5c6d1
       |-- fabric-crash-report-info-v1 0.2.29+0af3f5a7d1
       |-- fabric-data-attachment-api-v1 1.1.27+6a6dfa19d1
       |-- fabric-data-generation-api-v1 20.2.16+16c4ae25d1
       |-- fabric-dimensions-v1 4.0.0+6fc22b99d1
       |-- fabric-entity-events-v1 1.6.12+6fc22b99d1
       |-- fabric-events-interaction-v0 0.7.12+ba9dae06d1
       |-- fabric-game-rule-api-v1 1.0.53+6ced4dd9d1
       |-- fabric-item-api-v1 11.0.0+afdfc921d1
       |-- fabric-item-group-api-v1 4.1.4+78017270d1
       |-- fabric-key-binding-api-v1 1.0.47+0af3f5a7d1
       |-- fabric-keybindings-v0 0.2.45+df3654b3d1
       |-- fabric-lifecycle-events-v1 2.3.12+6c1df360d1
       |-- fabric-loot-api-v2 3.0.14+3f89f5a5d1
       |-- fabric-loot-api-v3 1.0.2+3f89f5a5d1
       |-- fabric-message-api-v1 6.0.13+6573ed8cd1
       |-- fabric-model-loading-api-v1 2.0.0+fe474d6bd1
       |-- fabric-networking-api-v1 4.2.2+60c3209bd1
       |-- fabric-object-builder-api-v1 15.2.0+a551f7a4d1
       |-- fabric-particles-v1 4.0.2+6573ed8cd1
       |-- fabric-recipe-api-v1 5.0.12+65089712d1
       |-- fabric-registry-sync-v0 5.1.2+60c3209bd1
       |-- fabric-renderer-api-v1 3.4.0+c705a49cd1
       |-- fabric-renderer-indigo 1.7.0+c705a49cd1
       |-- fabric-renderer-registries-v1 3.2.68+df3654b3d1
       |-- fabric-rendering-data-attachment-v1 0.3.48+73761d2ed1
       |-- fabric-rendering-fluids-v1 3.1.6+b5597344d1
       |-- fabric-rendering-v0 1.1.71+df3654b3d1
       |-- fabric-rendering-v1 5.0.5+df16efd0d1
       |-- fabric-resource-conditions-api-v1 4.3.0+8dc279b1d1
       |-- fabric-resource-loader-v0 1.3.0+56599129d1
       |-- fabric-screen-api-v1 2.0.24+b5597344d1
       |-- fabric-screen-handler-api-v1 1.3.86+b5597344d1
       |-- fabric-sound-api-v1 1.0.23+6573ed8cd1
       |-- fabric-transfer-api-v1 5.1.16+3dccd343d1
       \-- fabric-transitive-access-wideners-v1 6.1.0+176f9036d1
    - fabric-language-kotlin 1.12.0+kotlin.2.0.10
       |-- org_jetbrains_kotlin_kotlin-reflect 2.0.10
       |-- org_jetbrains_kotlin_kotlin-stdlib 2.0.10
       |-- org_jetbrains_kotlin_kotlin-stdlib-jdk7 2.0.10
       |-- org_jetbrains_kotlin_kotlin-stdlib-jdk8 2.0.10
       |-- org_jetbrains_kotlinx_atomicfu-jvm 0.25.0
       |-- org_jetbrains_kotlinx_kotlinx-coroutines-core-jvm 1.8.1
       |-- org_jetbrains_kotlinx_kotlinx-coroutines-jdk8 1.8.1
       |-- org_jetbrains_kotlinx_kotlinx-datetime-jvm 0.6.0
       |-- org_jetbrains_kotlinx_kotlinx-io-bytestring-jvm 0.5.1
       |-- org_jetbrains_kotlinx_kotlinx-io-core-jvm 0.5.1
       |-- org_jetbrains_kotlinx_kotlinx-serialization-cbor-jvm 1.7.1
       |-- org_jetbrains_kotlinx_kotlinx-serialization-core-jvm 1.7.1
       \-- org_jetbrains_kotlinx_kotlinx-serialization-json-jvm 1.7.1
    - fabricloader 0.15.11
    - fabrictailor 2.5.0
       \-- config2brigadier 1.2.3
    - farmtweaks 1.1+1.21
    - faster-random 4.1.0
    - ferritecore 7.0.0
    - filament 0.4-SNAPSHOT+1.21
       |-- bil 1.1.9+1.21
       \-- fabric-permissions-api-v0 0.3.1
    - flatbedrock 87.0.0
    - getittogetherdrops fabric-1.21-1.3.1
    - giantspawn 5.2
    - glideaway 1.2.0+1.21
       \-- common-protection-api 1.0.0
    - glore 1.4.0
    - grindenchantments 3.2.2+1.21-rc1
       \-- codec-config-api 2.0.0+1.20.5-rc3
    - grindstonesharpertools 3.7
    - hoetweaks 3.5
    - horsebuff 2.1.8
    - illagerexp 1.2.0
       |-- mm 2.3
       |-- server_translations_api 2.3.1+1.21-pre2
       \-- sgui 1.6.0+1.21
    - jade 15.0.4+fabric
    - java 21
    - justmobheads 8.3
    - linkart 5.4.5-1.20.6-build.29
       \-- dark-matter-base 4.0.0-1.20.1-build.481
    - lithium 0.12.7
    - machine_gun_blaze 0.1.2+1.21
    - metalwings 1.0.0
    - minecord 2.1.0+1.21
       |-- minecord-api 2.0.1+1.21
       |    \-- cloth-config 15.0.127
       |         \-- cloth-basic-math 0.6.1
       |-- minecord-chat 2.1.0+1.21
       |-- minecord-cmds 2.0.1+1.21
       \-- minecord-presence 2.0.0+1.21
    - minecraft 1.21
    - mob_armor_trims 2.4.1
    - modernfix 5.18.3+mc1.21
    - mods-command 1.1.7
       |-- adventure-platform-fabric 5.14.0
       |    |-- net_kyori_adventure-api 4.17.0
       |    |-- net_kyori_adventure-key 4.17.0
       |    |-- net_kyori_adventure-platform-api 4.3.3
       |    |-- net_kyori_adventure-text-logger-slf4j 4.17.0
       |    |-- net_kyori_adventure-text-minimessage 4.17.0
       |    |-- net_kyori_adventure-text-serializer-ansi 4.17.0
       |    |-- net_kyori_adventure-text-serializer-gson 4.17.0
       |    |-- net_kyori_adventure-text-serializer-json 4.17.0
       |    |-- net_kyori_adventure-text-serializer-plain 4.17.0
       |    |-- net_kyori_ansi 1.0.3
       |    |-- net_kyori_examination-api 1.3.0
       |    |-- net_kyori_examination-string 1.3.0
       |    \-- net_kyori_option 1.0.0
       |-- cloud 2.0.0-beta.7
       |    |-- fabric-permissions-api-v0 0.3.1
       |    |-- io_leangen_geantyref_geantyref 1.3.15
       |    |-- org_incendo_cloud-brigadier 2.0.0-beta.8
       |    |-- org_incendo_cloud-core 2.0.0-rc.2
       |    |-- org_incendo_cloud-minecraft-modded-common-fabric-repack_ 2.0.0-beta.7
       |    \-- org_incendo_cloud-services 2.0.0-rc.2
       |-- org_incendo_cloud-minecraft-extras 2.0.0-beta.9
       |-- org_spongepowered_configurate-core 4.2.0-SNAPSHOT
       |-- org_spongepowered_configurate-hocon 4.2.0-SNAPSHOT
       \-- org_spongepowered_configurate-yaml 4.2.0-SNAPSHOT
    - monkeyconfig 0.1.2+1.21
       |-- com_electronwill_night-config_core 3.7.2
       |-- com_electronwill_night-config_hocon 3.7.2
       |-- com_electronwill_night-config_json 3.7.2
       |-- com_electronwill_night-config_toml 3.7.2
       |-- com_electronwill_night-config_yaml 3.7.2
       \-- sgui 1.6.0+1.21
    - moretools 1.6.0+1.21
    - naturallychargedcreepers 3.5
    - noisium 2.2.0+mc1.21
    - offlinecommands 1.0.1+1.21
    - ouch 1.0.1+1.21
       \-- predicate-api 0.5.2+1.21
    - perplayerwanderingtraders 1.0.2+1.20.6
    - pl3xmap 1.21-507
    - placeholder-api 2.4.0+1.21
    - polydecorations 0.4.0+1.21
       |-- common-protection-api 1.0.0
       |-- map-canvas-api 0.4.0+1.21
       \-- sgui 1.6.0+1.21
    - polydex 1.2.1+1.21
       |-- player-data-api 0.6.0+1.21
       |-- server_translations_api 2.3.1+1.21-pre2
       |-- sgui 1.6.0+1.21
       \-- sidebar-api 0.5.0+1.21
    - polydex-bridge 1.0.0+mc.1.21
    - polyfactory 0.4.0-pre.5+1.21
       |-- common-protection-api 1.0.0
       |-- factorytools 0.3.1+1.21
       |-- graphlib 2.0.0-beta.1+1.21
       |    |-- codextra 2.0.0+1.21
       |    \-- common_events 1.0.0+1.21
       |-- map-canvas-api 0.4.0+1.21
       |-- sgui 1.6.0+1.21
       \-- sidebar-api 0.5.0+1.21
    - polymer-bundled 0.9.2+1.21
       \-- polymer-autohost 0.9.2+1.21
            \-- io_netty_netty-codec-http 4.1.82
    - polymer-rocks 1.0.0-pre.2
       |-- factorytools 0.3.1+1.21
       |-- mixinextras 0.4.0
       \-- polymer-blocks 0.9.6+1.21
    - profundis 1.7.1
    - quickleafdecay 0.2.5
    - quicksort 0.10.0+1.21
    - realisticbees 4.0
    - rocks 1.8.2
       \-- midnightlib 1.5.7
    - scaffoldingdropsnearby 3.3
    - scripts-chunk-loaders mc1.21-0.3.1
    - shareenderchest 1.6.3
    - skeletonhorsespawn 4.0
    - spark 1.10.73
       \-- fabric-permissions-api-v0 0.3.1
    - sswaystones 1.1.0
       |-- polymer-virtual-entity 0.9.8+1.21
       |-- server_translations_api 2.3.1+1.21-pre2
       \-- sgui 1.6.0+1.21
    - stopdropnroll 1.0.0
    - styledchat 2.6.0+1.21
       |-- fabric-permissions-api-v0 0.3.1
       \-- player-data-api 0.6.0+1.21
    - tabtps-fabric 1.3.24
       |-- adventure-platform-fabric 5.14.0
       |    |-- net_kyori_adventure-api 4.17.0
       |    |-- net_kyori_adventure-key 4.17.0
       |    |-- net_kyori_adventure-platform-api 4.3.3
       |    |-- net_kyori_adventure-text-logger-slf4j 4.17.0
       |    |-- net_kyori_adventure-text-minimessage 4.17.0
       |    |-- net_kyori_adventure-text-serializer-ansi 4.17.0
       |    |-- net_kyori_adventure-text-serializer-gson 4.17.0
       |    |-- net_kyori_adventure-text-serializer-json 4.17.0
       |    |-- net_kyori_adventure-text-serializer-plain 4.17.0
       |    |-- net_kyori_ansi 1.0.3
       |    |-- net_kyori_examination-api 1.3.0
       |    |-- net_kyori_examination-string 1.3.0
       |    \-- net_kyori_option 1.0.0
       |-- cloud 2.0.0-beta.7
       |    |-- fabric-permissions-api-v0 0.3.1
       |    |-- io_leangen_geantyref_geantyref 1.3.15
       |    |-- org_incendo_cloud-brigadier 2.0.0-beta.8
       |    |-- org_incendo_cloud-core 2.0.0-rc.2
       |    |-- org_incendo_cloud-minecraft-modded-common-fabric-repack_ 2.0.0-beta.7
       |    \-- org_incendo_cloud-services 2.0.0-rc.2
       |-- com_typesafe_config 1.4.3
       |-- net_kyori_adventure-serializer-configurate4 4.17.0
       |-- net_kyori_adventure-text-feature-pagination 4.0.0-SNAPSHOT
       \-- net_kyori_adventure-text-serializer-legacy 4.17.0
    - tectonic 2.4.1
    - televator 1.1.6+1.21
       |-- polymer-autohost 0.9.2+1.21
       |    \-- io_netty_netty-codec-http 4.1.82
       \-- server_translations_api 2.3.1+1.21-pre2
    - toms_mobs 2.0.0+1.21
       \-- bil 1.1.9+1.21
    - trinkets 3.10.0+polymerport.1
       |-- cardinal-components-base 6.1.0
       |-- cardinal-components-entity 6.1.0
       |-- player-data-api 0.6.0+1.21
       |-- server_translations_api 2.3.1+1.21-pre2
       \-- sgui 1.6.0+1.21
    - tsa-concrete 1.0.2+1.21
    - tsa-planks 1.0.2+1.21
    - tsa-stone 1.0.3+1.21
    - universal-graves 3.4.1+1.21
       |-- common-protection-api 1.0.0
       |-- server_translations_api 2.3.1+1.21-pre2
       \-- sgui 1.6.0+1.21
    - villagerdeathmessages 3.5
    - villagesandpillages 1.0.1
    - yungsapi 1.21-Fabric-5.0.0
       |-- org_javassist_javassist 3.29.2-GA
       \-- org_reflections_reflections 0.10.2
    - zombiehorsespawn 5.1

noiverre commented 2 months ago

I don't know if this is intentional or not, but Iron Vein Hammer break blocks in around 2x3 blocks area, haven't tested it with other types, it would be cool if each material has different vein mining radius

JongWasTaken commented 2 months ago

Hello, and thank you for reporting this!

The block breaking speed thing is indeed a bug, which got in during the port to 1.21.
Essentially the way mining speed is calculated changed, and I didn't test this much.
This has been fixed now, though I am kinda unsure what the speed should be for non-compatible blocks, so this might need some further adjustments down the line.

As for the vein hammer radius, I changed it now so that it is bigger when used on ores, otherwise it will still be 3.
Higher material tiers now have higher radii: wood still has 3, but with each tier it gets increased by 1, e.g. netherite now has a range of 7.

Both of these changes are in version 1.6.1, which I just uploaded to CurseForge and Modrinth, though CurseForge takes a while to approve the file.

Thank you and have a great day!