Jonghakseo / chrome-extension-boilerplate-react-vite

Chrome Extension Boilerplate with React + Vite + Typescript
MIT License
2.15k stars 314 forks source link

Injecting scripts from popup for latest version #516

Closed PatrykKuniczak closed 1 month ago

PatrykKuniczak commented 2 months ago

Are we want to implement injecting scripts like in #494 also for latest version, cause now we will have it only for legacy.

I think this could be good idea.

PatrykKuniczak commented 2 months ago

@Jonghakseo What's decision?

Jonghakseo commented 1 month ago

I don't think it's that hard to implement, and once the template suggested in the issue above is created, we can add it as one of the use cases. :)

PatrykKuniczak commented 1 month ago

I don't think it's that hard to implement, and once the template suggested in the issue above is created, we can add it as one of the use cases. :)

You mean what i mention in the #182 to give users option to generate only that part which they want to use, with generator #524 ?

PatrykKuniczak commented 1 month ago

We can do it like modules, like e.g Nest have, if user want, then install next. package with e.g authentication, but for now i think it's good idea to implement it for current code base, because people which are contributing can use this, as you can see several people https://github.com/Jonghakseo/chrome-extension-boilerplate-react-vite/pull/329#issuecomment-2171666012 waiting for that in legacy, i think it's high probability somebody waiting in latest version "__"

PatrykKuniczak commented 1 month ago

That's no doubt this is overengineering monster, i struggling when i need to do some changes, i think for people which want to contribute now it's about to impossible xD

After turborepo update, i need to spend so much time to know what's going on.

I think overall we can create this feature, but in the near future(closer to the end of the year), we can talk about big refactor, maybe we can talk with each other on discord after #562 and refactor this monster into more familiar like mentioned above NestJS

PatrykKuniczak commented 1 month ago

closed #579