Fix husky pre-commit giving deprecation notice - Githubissues

Jonghakseo / chrome-extension-boilerplate-react-vite

Chrome Extension Boilerplate with React + Vite + Typescript

MIT License

2.43k stars 357 forks source link

Fix husky pre-commit giving deprecation notice #647

Closed justinhaaheim closed 3 months ago

justinhaaheim commented 3 months ago

* Please fill in the required items.

Priority*

[ ] High: This PR needs to be merged first for other tasks.
[ ] Middle: This PR should be merged quickly to prevent conflicts due to common changes. (default)
[x] Low: This PR does not affect other tasks, so it can be merged later.

Purpose of the PR*

Husky v9 now prints a deprecation notice on every commit:

husky - DEPRECATED

Please remove the following two lines from .husky/pre-commit:

#!/usr/bin/env sh
. "$(dirname -- "$0")/_/husky.sh"

They WILL FAIL in v10.0.0

This fixes that according to https://github.com/typicode/husky/releases/tag/v9.0.1

How to check the feature

Commits now no longer print the deprecation warning.

PatrykKuniczak commented 3 months ago

@justinhaaheim Good job 😄