fix/tw-classnames-output-#627

PatrykKuniczak commented 3 months ago

* Please fill in the required items.

Priority*

[x] High: This PR needs to be merged first for other tasks.
[ ] Middle: This PR should be merged quickly to prevent conflicts due to common changes. (default)
[ ] Low: This PR does not affect other tasks, so it can be merged later.

Purpose of the PR*

I can't open PR to fork, that's why i created this PR.

This is related to #627.

I fixed that fix :)

Solution from #627 wasn't good enough because of the never ending build and it's still don't work properly.

Changes*

I added concurrently for run both watch scripts on the same time, now it was running independly.

Without that, only first script works. If i placed vite first then tailwind output file wasn't regenerated. Else Vite don't run and HMR don't refresh page.

I added also -m flag, for minify output file.

And i added dist folder inside content-ui

How to check the feature

Edit files from content-ui page.

codergigachad commented 3 months ago

My solution was a beginner solution, thanks for fixing it like an expert.

PatrykKuniczak commented 3 months ago

My solution was a beginner solution, thanks for fixing it like an expert.

Thanks, but i don't feel like an expert.

You've found that issue, which we're not aware, that's also very helpful 😄

codergigachad commented 3 months ago

@PatrykKuniczak any progress here? cause this is very important.

PatrykKuniczak commented 3 months ago

@PatrykKuniczak any progress here? cause this is very important.

We're waiting for @Jonghakseo review

PatrykKuniczak commented 3 months ago

@codergigachad OO maybe he done review, before my message, i'm on mobile then and don't see all messages :)

I will take a look to merge it today.

PatrykKuniczak commented 3 months ago

@Jonghakseo I belived i had to check, because i was thinking if this env will be resolved properly.

Good to you, thank for the second check ❤️

Jonghakseo / chrome-extension-boilerplate-react-vite