search

Jonghakseo / chrome-extension-boilerplate-react-vite

Chrome Extension Boilerplate with React + Vite + Typescript
MIT License
2.43k stars 357 forks source link

Running pnpm build script for prod should not result in a dev build #674

Closed gradywetherbee closed 2 months ago

gradywetherbee commented 2 months ago

Describe the bug When I quit the development server and run pnpm build, the resulting build still appears to be a dev build.

To Reproduce Steps to reproduce the behavior:

  1. Run pnpm dev
  2. Hit Cmd/Ctrl + C to kill your terminal
  3. Run pnpm build
  4. Remove the extension in your browser and reload

Expected behavior Extension should run a clean production build

Screenshots & current behavior Extension appears to be running a development build still. Extension page shows the following error:

WebSocket connection to 'ws://localhost:8081/' failed: Error in connection establishment: net::ERR_CONNECTION_REFUSED
image

Desktop (please complete the following information):

github-actions[bot] commented 2 months ago

Thank you for your contribution. We will check and reply to you as soon as possible.

PatrykKuniczak commented 2 months ago

Let's see #477

That's not related to pnpm build but, this occur when you break pnpm dev and then WSS server were stopped, and script from client still trying to connect server and this error occur.

If you clear errors and refresh plugin after build then, you should have working version.

If still it still doesn't work for you, feel free to reopen 😄