search

Jonghakseo / chrome-extension-boilerplate-react-vite

Chrome Extension Boilerplate with React + Vite + Typescript
MIT License
2.26k stars 329 forks source link

Taking packages from root #714

Open PatrykKuniczak opened 2 weeks ago

PatrykKuniczak commented 2 weeks ago

Is your feature request related to a problem? Please describe. We need to install package when we want to use it inside some module, but in the same time this package are installed on root package.json

Describe the solution you'd like I think it could be good idea to install packages which are used by min. 2 packages in root package.json and then inherit it inside specific module tsconfig.json under the includes key.

PatrykKuniczak commented 2 weeks ago

It's proabably not the best idea, because other deps, checking deps from specific package and take it from there as peer dep.

And if for e.g. chrome-extension @types/node doesn't exist, then it takes latest version, which cause errors like this: image

For our usages we can include it from root inside tsconfig.json but it's problem for other deps, more safe option is add all necessary packages for each module, inside this module(The most reliable solution).

@Jonghakseo Gimme your statement about it I'll create hotfix for that error in minutes