Jonghakseo / chrome-extension-boilerplate-react-vite

Chrome Extension Boilerplate with React + Vite + Typescript
MIT License
2.44k stars 361 forks source link

DevTools icon doesn't be shown on chrome #742

Open PatrykKuniczak opened 2 months ago

PatrykKuniczak commented 2 months ago

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  1. Run pnpm build or pnpm dev
  2. Load extension
  3. See options in devtools console

Expected behavior Icon should be shown as on Firefox.

Screenshots Chrome: image

Firefox: image

Desktop (please complete the following information):

govza commented 2 months ago

Works on MS Edge too.

PatrykKuniczak commented 2 months ago

Works on MS Edge too.

Each indeed, only chrome have this problem

govza commented 2 months ago

I don't think Chrome supports icons in the devtools at all.

Pretty old issues on chromium tracker. https://issues.chromium.org/issues?q=canonicalid:40329463

Also there no other icons on devtools panel tabs, compared to Edge for example.

Chrome image Edge image

PatrykKuniczak commented 2 months ago

@govza As you can see, react devtools have icons, hymm, maybe they set it inside text, that's probably it, because those icons are the same hight as text

govza commented 2 months ago

Looks like, they do inline icon

PatrykKuniczak commented 2 months ago

Looks like, they do inline icon

Yeah, that's what i've though. And there's a question, we want to do it or not @Jonghakseo ?

Jonghakseo commented 2 months ago

Looks like, they do inline icon

Yeah, that's what i've though. And there's a question, we want to do it or not @Jonghakseo ?

What does that mean? Do you have any ideas to support icons in DevTools? or just implement like React DevTools?

PatrykKuniczak commented 2 months ago

Looks like, they do inline icon

Yeah, that's what i've though. And there's a question, we want to do it or not @Jonghakseo ?

What does that mean? Do you have any ideas to support icons in DevTools? or just implement like React DevTools?

Like React DevTools