[Bug] `isStackOnBottom` and `stackedCardsCount` not working on 2.3.0

JoniVR / VerticalCardSwiper

A marriage between the Shazam Discover UI and Tinder, built with UICollectionView in Swift.

MIT License

1.39k stars 100 forks source link

[Bug] `isStackOnBottom` and `stackedCardsCount` not working on 2.3.0 #78

Closed IDontEatMeat closed 3 years ago

IDontEatMeat commented 3 years ago

Bottom stacking won't work anymore with 2.3.0. I had to downgrade after wasting 3 hours not knowing what is going on. If someone else encounters this issue it is because of the new version. stackedCardsCount and isStackOnBottom have no effect whatsoever.

JoniVR commented 3 years ago

Hi, you are correct, I've discovered the issue was introduced in #76, will work on a fix.

IDontEatMeat commented 3 years ago

Thanks, great project btw 👍

stfnhdr commented 3 years ago

fixed issue in PR #79

IDontEatMeat commented 3 years ago

awesome thanks

JoniVR commented 3 years ago

This is now fixed in the new release, thanks @stfnhdr for opening a PR and @IDontEatMeat for reporting!