search

JonnyBooker / split-flap

Code for split-flap display based on: https://github.com/Dave19171/split-flap
https://www.prusaprinters.org/prints/69464-split-flap-display
GNU General Public License v3.0
38 stars 6 forks source link

LinkedList #1

Closed Lo0kadistraction closed 8 months ago

Lo0kadistraction commented 8 months ago

ESPMaster will not compile due to error with LinkedList I have installed the linked list from the library manger. https://github.com/ivanseidel/LinkedList That did not seem to help. Please advise.

chris-guthrie commented 8 months ago

The problem is related to LinkedList library clashing with ESPAsyncWebServer, you can see a work around listed on this issue report.

https://github.com/ivanseidel/LinkedList/issues/40

Lo0kadistraction commented 8 months ago

That's a good fix! Include the LList.h and refactor all LinkedList references to LList and its good to go. thank you!

stokes776 commented 7 months ago

How do I apply this workaround? Do I need to go edit the file in \split-flap-master\ArduinoLibraries\ESPAsyncWebServer-master.zip\ESPAsyncWebServer-master\src\ESPAsyncWebServer.h

If so, what do I add or remove or comment out? Sorry, I did click around to the linked issue but I am afraid I don't know what it means to Add wrapper namespace to workaround Async Webserver Class name collision Is that something I do, or something they already did?

EDIT: I believe I see my issue. I had previously installed ESPAsyncWebServer, I need to uninstall/reinstall it using the provided Zip files, as they have already been fixed. Just the zips being there is not being installed.

JonnyBooker commented 5 months ago

@Lo0kadistraction I am so so sorry! I never saw this get opened as an issue! I will try pay more close attention. Hope the rest of the build went more smoothly for you

@stokes776 I'm glad you solved your issue. The way I got around it was by modifying the original ESPAsyncWebServer library and including it as a zip here in this repository. Looks like you realised that. The wording I used for including the libraries I can look to improve in the readme.

JonnyBooker commented 4 months ago

@chris-guthrie - Thank you for your link for a workaround. I'm going to do a release in the near future which will include this change so I will include you on the release notes as a thank you :)