JonnyBro / beatrun

Fork of infamous parkour addon for Garry's Mod
https://beatrun.jonnybro.ru
Do What The F*ck You Want To Public License
240 stars 40 forks source link

[Bug] Can't Safety Roll After Jumping Off A Swing Rope #124

Closed CootieDwagon closed 4 months ago

CootieDwagon commented 11 months ago

Describe the bug: when jumping off a swing rope, you can NOT roll by pressing left ctrl key. you can however roll by pressing left shift.

Steps to reproduce the behavior:

  1. load up any map
  2. spawn in a swing rope
  3. swing from the rope, jump and try to roll with left ctrl key
  4. you won't be able to roll with left ctrl key

Expected behavior: I thought a swing rope would be similar to a grapple hook in some ways. with the grapple hook, if you jump off from it you can roll by pressing left ctrl key and left shift.

Additional information:

Additional context: so with the grapple hook, you can roll if you press left ctrl key, but this does not work for swing ropes. which is weird cause the only difference really between them is, one can be used in free mode and the other is used for courses to "swing" on.

c4nkerm3me commented 4 months ago

Basically the issue here is that when you use a grappling hook, the crouch jump isn't disabled. But when using a swing rope, its usually disabled. Safety Roll works with three different keybinds, defined by "IN_DUCK", "IN_SPEED" or "IN_BULLRUSH", not just one. But because of crouch jump being disabled, Safety Roll only uses "IN_SPEED" and "IN_BULLRUSH". The opposite happens when its not disabled, it uses "IN_DUCK".

Here are the screenshots for reference and (what i assume) finding these issues. image image image

c4nkerm3me commented 4 months ago

The only issue I found with doing this, is that your character does weird stuff when trying to crouch jump. To prevent that, I'd enable crouch jumping ONLY when I jump off a grapple or swing rope. Not ALWAYS leave it enabled.

CootieDwagon commented 4 months ago

The only issue I found with doing this, is that your character does weird stuff when trying to crouch jump. To prevent that, I'd enable crouch jumping ONLY when I jump off a grapple or swing rope. Not ALWAYS leave it enabled.

you have found this information which is interesting... are you aware the same thing happens when you come off a zipline?

yeah, when you get off of a zipline, the left control key doesn't work to "safety roll" but the "left shift" key still works

JonnyBro commented 4 months ago

Fixed in https://github.com/JonnyBro/beatrun/commit/78f949eb66e4552be50b950975c415ff9ec55d72