Update dependencies to resolve ytdl-core issue "Could not find player config"

JonnyBurger / pipcorn

🍿 Watch YouTube videos on your Mac via CLI

MIT License

164 stars 5 forks source link

Update dependencies to resolve ytdl-core issue "Could not find player config" #6

Open emjayess opened 3 years ago

emjayess commented 3 years ago

Per this tweet: https://twitter.com/JNYBGR/status/1353760971261620228

And considering the now-in-the-past temporary DMCA trouble phase that ytdl / youtube-dl suffered in 2020, seems necessary to update to the latest available ytdl-core version: presently is 4.4.5.

prpss commented 3 years ago

so the issue is related to ytdl-core?

prpss commented 3 years ago

ig this issue can be resolved by #7 , please look at the referenced issue and give me your opinions on it.

emjayess commented 3 years ago

so the issue is related to ytdl-core?

Yes, the "could not find player config" problem is due to outdated dependency on ytdl-core... I spent a few minutes attempting to rebuild and test with updated dependencies, but it still didn't build clean, or something; I had trouble running it and didn't have time to sort out why.

prpss commented 3 years ago

Oh okay 👍