JonnyDawe / UK-Sewage-Map

This map shows real-time information about river sections that might be affected by sewage discharges from combined sewer overflows. Currently, it is limited to the Thames basin.
https://sewagemap-jonnydawe.vercel.app
MIT License
4 stars 1 forks source link

Better handle and display "offline" monitors #14

Closed AlexLipp closed 3 months ago

AlexLipp commented 4 months ago

Problem

Currently, the map opts to not display offline monitors as icons. This behaviour has a potentially unwanted or surprising affect of EDM monitors "disappearing" if they switch to offline. A consequence of this is that a user is unable to read the discharge history of a monitor that is currently offline, even if the history of that monitor is still accessible.

Additionally, currently, the history "barchart" does not display periods when the monitor is offline. Consequently, a period of time when a monitor is discharging continuously but "offline" will be seen the same as "not discharging", which is undesirable.

Solutions

Present

Offline monitors could be displayed as greyed out icons that can still be clicked on, similar to the display on the Thames Water EDM map.

History

Offline periods can be displayed as greyed out rectangles, similar to their base display in POOPy, e.g: image

This would require further back-end calculations but can be included trivially (it is raised as an issue on the back-end documentation as well)