search

JonnyHaystack / HayBox

Modular cross-platform firmware for digital or mixed analog/digital game controllers
GNU General Public License v3.0
182 stars 231 forks source link

R4 profile, XInput backend improvements, etc. #58

Closed avahe-kellenberger closed 9 months ago

avahe-kellenberger commented 1 year ago

Github is currently showing many changes in files which actually have no difference between the master branch and my fork. I'm partially opening this PR to see if it fixes the comparison.

ribbanya commented 11 months ago

@avahe-kellenberger Could you summarize any changes in this PR (or other findings you've come across) that would pertain to #26? I'd like to get that merged at some point.

ribbanya commented 11 months ago

By the way, if you use a two-dot comparison then the problem mentioned in the OP should resolve, like this.

avahe-kellenberger commented 11 months ago

The problem showing randomly changed files was fixed, which is nice.

The primary changes of the PR are adding an Ultimate mode for the R4 B0xx. It works well. I've also made minor changes to DInput and XInput which fixed some small issues, I'll leave some comments on the code.

ribbanya commented 11 months ago

That all makes sense! Thanks for taking the time to explain.