search

JonnyJD / musicbrainz-isrcsubmit

script to submit ISRCs from disc to musicbrainz
http://jonnyjd.github.io/musicbrainz-isrcsubmit/
GNU General Public License v3.0
40 stars 13 forks source link

Failed install on macOS 10.12 #116

Closed CyberSkull closed 5 years ago

CyberSkull commented 7 years ago

I got a failed install when I tried via pip on macOS 10.12:

Complete output from command python setup.py egg_info: Traceback (most recent call last): File "", line 1, in File "/private/tmp/pip-build-N96uKZ/isrcsubmit/setup.py", line 13, in from isrcsubmit import version File "isrcsubmit.py", line 55, in import discid ImportError: No module named discid

Command "python setup.py egg_info" failed with error code 1 in /private/tmp/pip-build-N96uKZ/isrcsubmit/

CyberSkull commented 7 years ago

I managed to separately install discid, but it then threw this error:

Complete output from command python setup.py egg_info: Traceback (most recent call last): File "", line 1, in File "/private/tmp/pip-build-HVDznY/isrcsubmit/setup.py", line 13, in from isrcsubmit import version File "isrcsubmit.py", line 57, in import musicbrainzngs ImportError: No module named musicbrainzngs

Command "python setup.py egg_info" failed with error code 1 in /private/tmp/pip-build-HVDznY/isrcsubmit/

CyberSkull commented 7 years ago

I managed to install it after manually installing the two dependancies.

JonnyJD commented 5 years ago

Yes, isrcsubmit needs python-discid and musicbrainzngs.

Sorry, the setup script is not a complete standalone package installer which installs all dependencies with it, like people are used to. Making such a thing requires a substantial amount of work (and somebody who develops on Mac)

eli-schwartz commented 5 years ago

Please remove the dependencies from setup.py then, as they are a lie and don't work because you don't consider using setup.py according to its intended purpose, to be a valid use case.

Somehow, nearly every other python package in existence manages to be a dependency manager with absolutely no effort whatsoever. That's why pip exists. But I guess you know better.

...

Side note: this error has nothing to do with macOS, as it is trivially reproducible on every operating system ever, merely by following the PyPA recommended method for installing every setup.py-based package ever, which works, plus yours, which doesn't.