JonnyJD / musicbrainz-isrcsubmit

script to submit ISRCs from disc to musicbrainz
http://jonnyjd.github.io/musicbrainz-isrcsubmit/
GNU General Public License v3.0
40 stars 13 forks source link

Add support for ISRCs from Digital Files #137

Open SheamusPatt opened 2 years ago

SheamusPatt commented 2 years ago

I'd previously logged an issue (enhancement request) to add support for audio files, (#135). I've developed this script to address that need. It would have greatly complicated the isrcsubmit command line to make it serve both purposes, so instead I created a new script, isrcDigitalSubmit. It relies heavily on the original isrcsubmit for many functions, though, so it makes sense to include both scripts in the same package. The shared code has been moved into an internal module, isrcshared.py . I have updated the test framework as needed so it still runs, but have not created any new tests. The script has been tested using my library of several dozen purchased digital downloads, and I also did some rudimentary testing on Windows 10. It's there I discovered that isrcsubmit requires 32-bit Python (part of the reason I created ishared.py as it avoids that dependency for isrcDigitalSubmit). I've also updated the packaging script so that it creates a working pair of release archives (though I only tested the Windows one as I don't have access to a MAC). Note that I dropped the mediatools download from the packaging as the host site seems to have gone.

This pull request is nearly the same as #136 (now closed) but fixes a broken import while refactoring, which causes the final "submit" to fail. It also adds support for the Mora store which apparently uses its own GUID as a tag for ISRC. Confirmed by one of its users.