Run in same terminal

[jesus2099]

Summary

Patching the Windows-only isrcsubmit.bat file.

Without this patch

• The standard output is displayed in another temporary terminal window (no time to see it)
• The script always pauses at the end, even when ran from the command line (odd and annoying)

With this patch

• The standard output is displayed in current terminal window (like in Linux)
• If the script is run from command line, there is no annoying pause at the end (like in Linux)

---

I have a new PC with Windows 10 Pro and the isrcsubmit.bat command is unfortunately:

1. Launching isrcsubmit.py in new window
2. Closing this new window as soon as the script is ended
3. Pausing the parent window with nothing visible (as the script was run in new window, now closed)

Running python <path>\isrcsubmit.py instead of isrcsubmit.py fixes this problem.

I also fix the problem that work variable cp is added to environment variables. I keep it local to the script, instead, with setlocal.

---

I have also added a code to pause the script only when launched from file explorer, with mouse, and not when launched from command line.

[jesus2099]

https://github.com/JonnyJD/musicbrainz-isrcsubmit/assets/1401086/24b8ce18-f158-4ae6-934d-4107101cf24d

Here is what happens on my Windows 10 Professionnel 22H with Python 3.11.5.

First I run isrcsubmit_original.bat which is the original download. You cannot see the new CMD.exe terminal window that appears and disappear with no time to read the output. Then back on the original terminal with the pause message, for nothing.

Then I run my patched isrcsubmit.bat which displays output in same original terminal and that does not show useless pause message.

I will add a commit that enables a pause message, only when launching isrcsubmit.bat from mouse double-click, there it is needed.

[jesus2099]

I have now added this code that will pause the script only when it is launched by mouse double-click (pause useful to see messages before terminal closes), and not when launched from CLI (pause useless):

echo %cmdcmdline%|findstr /c:"%~nx0" >nul
if %errorlevel% equ 0 echo.&pause

[jesus2099]

Same on my new new office laptop:

• Windows 10 Entreprise 22H2 x64
• Python 3.11.6
• Either CMD.exe or Windows Terminal

Maybe it's only an issue in Windows Terminal, No I reproduce same problem with CMD.exe right now, but anyway the new code is great because then the script pauses appropriately when run from mouse double-click from File Explorer and does not pause when run from a command line.